Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make XUnit2TestGeneratorProvider.SetTestMethod virtual #2555

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Make XUnit2TestGeneratorProvider.SetTestMethod virtual #2555

merged 2 commits into from
Feb 2, 2022

Conversation

JoshKeegan
Copy link
Contributor

Make XUnit2TestGeneratorProvider.SetTestMethod virtual so that it can be replaced by generator plugins.
I needed to make this change for a new feature in my generator plugin, src using it here: https://github.com/JoshKeegan/xRetry/blob/5494809b736bc50c8bcdf24ece71b6623a2f6d4c/src/xRetry.SpecFlow/TestGeneratorProvider.cs#L35

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Performance improvement
  • Refactoring (so no functional change)
  • Other (docs, build config, etc)

Checklist:

  • I've added tests for my code. (most of the time mandatory)
  • I have added an entry to the changelog. (mandatory)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@JoshKeegan JoshKeegan mentioned this pull request Jan 31, 2022
Merged
@SabotageAndi
Copy link
Contributor

Sure, no problem to make this virtual.

@SabotageAndi SabotageAndi merged commit 578780a into SpecFlowOSS:master Feb 2, 2022
@SabotageAndi
Copy link
Contributor

@JoshKeegan this change is released to nuget.org

@JoshKeegan
Copy link
Contributor Author

@JoshKeegan this change is released to nuget.org

Thanks!

bollhals pushed a commit to bollhals/SpecFlow that referenced this pull request Mar 11, 2022
@JoshKeegan @bollhals
Make XUnit2TestGeneratorProvider.SetTestMethod virtual (SpecFlowOSS#2555
e752cf2 
)
Code-Grump pushed a commit to Code-Grump/SpecFlow that referenced this pull request Mar 29, 2023
@JoshKeegan @Code-Grump
Make XUnit2TestGeneratorProvider.SetTestMethod virtual (SpecFlowOSS#2555
44de3ee 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshKeegan @SabotageAndi